Fix where epicbox listener stop receiving txs. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneshahn
requested review from
who-biz,
fireice-uk,
skykingisepic and
blacktyger
skykingisepic
approved these changes
Nov 20, 2023
who-biz
approved these changes
Nov 21, 2023
| info!("Subscription Ok."); | ||
| let duration = | ||
| std::time::Duration::from_secs(EPICBOX_SUBSCRIPTION_INTERVAL); | ||
| std::thread::sleep(duration); |
There was a problem hiding this comment.
This behavior is fine for now. But, it looks to me like it is stopping response processing during the sleep. I'd like to handle this more gracefully moving forward.
But, we can handle that when we don't have a pending necessary release. ACK for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix solves the problem, where the epicbox listener does not refresh his subscription and blocks connection with the epicbox server.
Type of change
Tested on MacOs.
24h listener run with repeating receive tx,
send -m epicbox/txs/outputs/scan/info during listener runs