Revert ebox port changes, fixes encrypted data parsing error #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacktyger
reviewed
Aug 31, 2023
johanneshahn
approved these changes
Aug 31, 2023
blacktyger
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes committed in #90 included modification to
portmember of EpicboxAddress struct. This was done to ensure proper communication of port through workflow from: config file -> address -> wire (and back).However, changing type of
portmember fromOption<u16>tou16, affected the way Epicbox addresses are serialized and deserialized when being communicated between wallets/epicbox.Big thanks to @blacktyger for finding this bug, as it breaks backward compat with other wallets, resulting in the following error message:
As such, changes were reverted. This may mean we need to fix the port discernment again, but I will test that later. For now, default over 443 works.