Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debian packaging for v3.4.0 #84

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

who-biz
Copy link
Contributor

@who-biz who-biz commented Jun 14, 2023

Nearly identical commit to EpicCash/epic#94, does the same for epic-wallet.

Copy link

@danrmiller danrmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@who-biz
Copy link
Contributor Author

who-biz commented Jun 15, 2023

This needs a couple more changes before merge.

Something in debian/rules script is causing cargo to update dependencies, and it appears that epic-wallet is being built twice. The second time is failing. First appears successful.

ctrlc dependency is being updated to 3.4.0, rather than our Cargo.toml entry version 3.1. Versions up to 3.2.4 seem fine.

Will fix tomorrow. Might as well wait on approvals, unless someone else can spot the issue quickly.

- Prevents depedency update when running cargo install, which was causing a build failure due to version incompatibility
@who-biz
Copy link
Contributor Author

who-biz commented Jun 15, 2023

Issue mentioned above has been fixed by requiring cargo to use Cargo.lock versions of deps via: cargo install --locked in debian/rules script.

Copy link

@skykingisepic skykingisepic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@who-biz who-biz merged commit c5d01a2 into EpicCash:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants