State moment dependency on package.json as well #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you change that to 2.8.1 please. 2.8.0 was a quickly pulled out for a bug fixed in 2.8.1 |
|
bootstrap and jquery should be included as well if we are really going to include dependencies to package.json |
|
Mmm, true, big fail, other libraries should be there. The version of the dependency, as I understand it, will match the latest 2.8.x, so 2.8.1 as of right now, but I will bump as well to enforce it. I will force push an updated commit first thing in the (CEST) morning (unless you prefer a separate commit). |
|
no one commit/PR should be fine |
|
I've updated the dependencies. I tried to follow bower.json, but I don't know if it is the one most up to date. E.g., component.json points to jQuery 1.9.1. And all of them require moment 2.8.0. |
Eonasdan
added a commit
that referenced
this pull request
Aug 22, 2014
State moment dependency on package.json as well
suy
added a commit
to suy/bootstrap-datetimepicker
that referenced
this pull request
Aug 26, 2014
jQuery 1.8 doesn't work with browserify due to a bug in esprima triggered by internal dependencies not up to date. And Bootstrap ~3.0 doesn't match any version on npm. Changed matches to allow newer compatible versions. See also Issue Eonasdan#503 and Issue Eonasdan#501.
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.