Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disabledDates causes lateness and next /previous navigation issues #2658

Closed
RamonaBarbieru opened this issue Sep 20, 2022 · 5 comments
Closed

disabledDates causes lateness and next /previous navigation issues #2658

RamonaBarbieru opened this issue Sep 20, 2022 · 5 comments
Labels
Area: TypeScript Priority: Medium

Comments

@RamonaBarbieru
Copy link

When disabledDates is loaded with an long array of dates, it causes lateness. For 800 entries it takes around 20 seconds to show (I need 5 year worth of data). The issue is in _isInDisabledDates -> mapping on return statement because for every date shown it reprocesses all disabled dates.
DisabledDates
It would be a very quick fix to solve this, just remember the formatted disabled dates array on the first occurrence.
disabledDatesArray.txt

Another issue, also tied with disabled dates is that I cannot navigate next/previous month for all months.

I attached a file with dates that can be passed for testing.
@RamonaBarbieru RamonaBarbieru changed the title disabledDates causes lateness and next /previous navigation affected disabledDates causes lateness and next /previous navigation issues Sep 20, 2022
@Eonasdan Eonasdan added Area: TypeScript State: planned This ticket is planned to be worked on. Priority: Medium labels Oct 24, 2022
@Eonasdan Eonasdan moved this to 🆕 New in Tempus Dominus Oct 24, 2022
@Eonasdan Eonasdan moved this from 🆕 New to 📋 Backlog in Tempus Dominus Oct 24, 2022
@Eonasdan Eonasdan moved this from 📋 Backlog to 🔖 Ready in Tempus Dominus Oct 25, 2022
Eonasdan added a commit that referenced this issue Oct 25, 2022
@Eonasdan
Fixed disabled/enabled dates performance issue. This also should fix …
76c6e97 
…the next/previous month selection #2658
Eonasdan added a commit that referenced this issue Oct 25, 2022
@Eonasdan
Fixed disabled/enabled dates performance issue. This also should fix …
844f6a9 
…the next/previous month selection #2658
Eonasdan added a commit that referenced this issue Oct 25, 2022
@Eonasdan
Fixed disabled/enabled dates performance issue. This also should fix …
ca74e05 
…the next/previous month selection #2658
@Eonasdan
Copy link
Owner

Hi please check this branch https://github.com/Eonasdan/tempus-dominus/tree/2658-disableddates-causes-lateness-and-next-previous-navigation-issues.

Also.. I hope you aren't actually building a list of every single weekend cause there's an option to disable days of the week.

@Eonasdan Eonasdan moved this from 🔖 Ready to 👀 In review in Tempus Dominus Oct 25, 2022
@Eonasdan
Copy link
Owner

Here's a stackblitz of this working

@RamonaBarbieru
Copy link
Author

RamonaBarbieru commented Oct 28, 2022 •
edited
Loading

Hi. I checked it in my exact case and I can confirm the issues are fixed. Thank you.

@Eonasdan
Copy link
Owner

Awesome. I'll get this merged soon

@Eonasdan Eonasdan added State: Pending Release This issue has been resolved in the dev branch and is waiting on a new release and removed State: Waiting feedback State: planned This ticket is planned to be worked on. labels Oct 28, 2022
@Eonasdan Eonasdan moved this from 👀 In review to ✅ Done in Tempus Dominus Oct 28, 2022
Eonasdan added a commit that referenced this issue Oct 29, 2022
@Eonasdan
#2658
ea5996f
@Eonasdan Eonasdan mentioned this issue Oct 29, 2022
Merged
Eonasdan added a commit that referenced this issue Oct 29, 2022
@Eonasdan
6.2.6 (#2700)
4741bf7 
* #2658

* #2611

* 6.2.6
@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Oct 29, 2022
@Eonasdan
Copy link
Owner

This was released with 6.2.6

Repository owner moved this from 🚀 Released to ✅ Done in Tempus Dominus Oct 29, 2022
@Eonasdan Eonasdan moved this from ✅ Done to 🚀 Released in Tempus Dominus Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: TypeScript Priority: Medium
Projects
Tempus Dominus
Archived in project
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

2658-disableddates-causes-lateness-and-next-previous-navigation-issues Eonasdan/tempus-dominus
2 participants
@Eonasdan @RamonaBarbieru