Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organismal groupings for EBI/JGI GOLD microbiome terms #781

Open
kaiiam opened this issue May 27, 2019 · 12 comments
Open

organismal groupings for EBI/JGI GOLD microbiome terms #781

kaiiam opened this issue May 27, 2019 · 12 comments
Assignees
Labels
GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary mapping

Comments

@kaiiam
Copy link
Contributor

kaiiam commented May 27, 2019

Cross link to #672

Within the EBI/JGI GOLD's root > Host-associated hierarchy there are a many organismal groupings which are not monophyletic clades, and cannot be described by an existing NCBITaxon semantic. Examples include Reptilia, Protists, Protozoa, Spiralia, fish and green algae.

@diatomsRcool @ramonawalls as I would like to have terms to link the new microbiome terms to, I am wondering which Ontology would be best suited host such organismal groupings, perhaps ECOCORE or PCO?

Perhaps under the organism hierarchy in ECOCORE as they already have some classes there such as algae, prey as well as the three domains of life imported from NCBITaxon?

@kaiiam
Copy link
Contributor Author

kaiiam commented May 29, 2019

There are also symbiosis-related terms which include Ectosymbionts, Extracellular symbionts, Intracellular endosymbionts (including primary and secondary), as well as Epibionts. @pbuttigieg and I agreed that these should likely go to ECOCORE.

@kaiiam kaiiam self-assigned this May 29, 2019
@cmungall
Copy link
Member

For GO taxon constraints we create non-monophyletic unions, e.g prok = arch OR bact

http://purl.obolibrary.org/obo/go/imports/go-taxon-groupings.owl

The specific owl module may not fit your needs but you could use the same approach. Define your classes using OWL DL constructs. Reason over these using hermit in advance to get your subclass hierarchy - don't assert.

@cmungall
Copy link
Member

We could release these alongside NCBITaxonm but it wouldn't be appropriate to have NCBITaxon IDs thouggh of course

@kaiiam
Copy link
Contributor Author

kaiiam commented May 30, 2019

@cmungall Ideally I would like to have resolvable purls to an ontology hosted on Ontobee, would it be possible to have defined classes which have such axioms or do you think this kind of approach is better?

@pbuttigieg
Copy link
Member

pbuttigieg commented May 31, 2019

The approach @cmungall suggests will likely get done faster, but having terms in ECOCORE / PCO would be more sustainable in the long run (unless EBI or another user means something very specific when they use such a grouping).

@diatomsRcool
Copy link
Contributor

I would like to work with @ramonawalls to figure out if ecocore or pco is more appropriate.

@cmungall
Copy link
Member

cmungall commented Jun 1, 2019 via email

@kaiiam
Copy link
Contributor Author

kaiiam commented Jun 4, 2019

@cmungall just to be clear my understanding of how you created the go-taxon-groupings.owl using DL constructs was that you did the following:

To create the Prokaryota class, in protege you go to the DL query tab

image

Then in the DL query box you add what becomes the equivalent to axiom:

NCBITaxon_2 or NCBITaxon_2157 Where NCBITaxon_2 is Bacteria and NCBITaxon_2157 is Archaea.

image

Then click the Add to ontology button? Then you run the HermiT reasoner and it will figure out the subclass hierarchy? Is this correct?

If @ramonawalls and @diatomsRcool decide to go with regular classes, couldn't we achieve the same effect by creating a new class and giving it an equivalence axiom for example NCBITaxon_2 or NCBITaxon_2157 for a prokaryotes class?

@cmungall
Copy link
Member

cmungall commented Jun 4, 2019 via email

@kaiiam
Copy link
Contributor Author

kaiiam commented Jun 4, 2019

I was looking into DL construction classes, and I thought that they were a different type of owl class more like owl lite, and that you would have to make it a different way in Protege but if the distinction isn't important then it probably doesn't matter.

We'd just create classes and give them equivalence axioms with OR's. Correct?

@cmungall
Copy link
Member

cmungall commented Jun 5, 2019 via email

@kaiiam
Copy link
Contributor Author

kaiiam commented Jun 5, 2019

Great thanks @cmungall. I'd be happy to make these contributions to ECOCORE and or PCO once it's settled where they should go.

@kaiiam kaiiam added the GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GOLD/EBI-MGNIFY Genomes OnLine Database GOLD Vocabulary mapping
Projects
None yet
Development

No branches or pull requests

4 participants