-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add command-line completions #131
Conversation
There is an issue when building if I try to generate completions in The Is not accessible since |
The code now compiles, but |
I will review this pr when i am back from vacation (20th) |
I will look into it this weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
There is a problem when I revert the changes, the generated completions are using the wrong binary name. |
For example, if I run _target/debug/typstyle() {
local i cur prev opts cmd
COMPREPLY=()
cur="${COMP_WORDS[COMP_CWORD]}"
prev="${COMP_WORDS[COMP_CWORD-1]}"
cmd=""
opts=""
for i in ${COMP_WORDS[@]}
# ... which is expected to be: _typstyle() {
# ... |
Trying to add command-line completions.
Closes #130