Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: private endpoints for key vault and adls #62

Merged
merged 16 commits into from
May 26, 2023

Conversation

RhysBushnell
Copy link
Contributor

📲 What

Add Private Endpoints to ADLS and Key Vault Modules

🤔 Why

Required as part of Secure Data Platform

🛠 How

More in-depth discussion of the change or implementation.

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR.

🕵️ How to test

Notes on how a reviewer can test the changes, e.g. how to run the tests.

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@Trishisingh Trishisingh self-requested a review May 26, 2023 09:28
@RhysBushnell RhysBushnell merged commit cf9251f into master May 26, 2023
@RhysBushnell RhysBushnell deleted the feature/pe-for-kv-adls branch May 26, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants