Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added sql module #46

Merged
merged 6 commits into from
Apr 17, 2023
Merged

feat: added sql module #46

merged 6 commits into from
Apr 17, 2023

Conversation

Trishisingh
Copy link
Contributor

📲 What

Added a Module for Azure SQL with DBs

🤔 Why

this is needed for Data Platform

🛠 How

Added resource of azure SQL
Added random password for SQL admin login
Added Azure admin logins as well
Added network files
Added Sql databases

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR.

🕵️ How to test

Notes on how a reviewer can test the changes, e.g. how to run the tests.

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@Trishisingh Trishisingh self-assigned this Apr 13, 2023
@Trishisingh Trishisingh added the enhancement New feature or request label Apr 13, 2023
@Trishisingh Trishisingh marked this pull request as ready for review April 17, 2023 09:02
@Trishisingh Trishisingh merged commit 07bb4e1 into master Apr 17, 2023
@ElvenSpellmaker ElvenSpellmaker deleted the feat-sql-module branch November 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants