Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 5959 add global parameter #45

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

Trishisingh
Copy link
Contributor

📲 What

added Global parameters to ADF

🤔 Why

Global Parameters are needed for Data Pipeline

🛠 How

Added Global Parameter resource Block

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR.

🕵️ How to test

Notes on how a reviewer can test the changes, e.g. how to run the tests.

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@Trishisingh Trishisingh added the enhancement New feature or request label Apr 11, 2023
@Trishisingh Trishisingh self-assigned this Apr 11, 2023
@Trishisingh Trishisingh marked this pull request as ready for review April 11, 2023 13:59
Copy link
Contributor

@satenderrathee satenderrathee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@satenderrathee satenderrathee merged commit 6783a85 into master Apr 11, 2023
@ElvenSpellmaker ElvenSpellmaker deleted the feat-5959-add-global-parameter branch November 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants