Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): Adds SNS to AWS App - 4700 #32

Merged
merged 11 commits into from
Jul 14, 2022
Merged

Conversation

williamayerst
Copy link
Member

📲 What

Implements AB#4700 - Add SNS topic/subscription to AWS App

🤔 Why

SNS topic/subscription was defined tactically in local app resource manifest instead of module and needs to be properly integrated.

🛠 How

Standard TF

👀 Evidence

Build

🕵️ How to test

No change to output

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

Copy link
Contributor

@russellseymour russellseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 👍

@williamayerst williamayerst merged commit 3d54b22 into master Jul 14, 2022
@ElvenSpellmaker ElvenSpellmaker deleted the feature/4700-sns branch November 20, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants