Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqs): add sqs as custom resource module #29

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

dibyadhar
Copy link
Contributor

@dibyadhar dibyadhar commented May 18, 2022

📲 What

  1. Add sqs as custom resource module compared to calling from https://registry.terraform.io/modules/terraform-aws-modules/sqs/aws/latest/examples/complete, this fixes the required output required from the module

  2. Update table-name and queue-name with environment prefix

🤔 Why

Certain output from sqs module is required to for CQRS and CQRS-Events Configuration

🛠 How

Add SQS Custom resource in sqs-output/aws/modules/resource_modules/application_integration

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR.

🕵️ How to test

git clone  https://github.com/amido/stacks-terraform.git
cd aws/modules/infrastructure_modules/stacks_app/example

terraform init
terraform plan -out tfpan
terraform apply 

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@dibyadhar dibyadhar merged commit d8da857 into master May 18, 2022
@dibyadhar dibyadhar deleted the fix/sqs-output branch May 18, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants