Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make additional policies & SA names optional #133

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ElvenSpellmaker
Copy link
Contributor

📲 What

Make additional policies & SA names optional

🤔 Why

They shouldn't be mandatory to pass as not all IRSA roles will have additional policies or SAs to assign

🛠 How

👀 Evidence

EKS Infra is broken atm because of it: https://github.com/Ensono/stacks-infrastructure-eks/actions/runs/10042624392/job/27753488973?pr=12

🕵️ How to test

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@ElvenSpellmaker ElvenSpellmaker merged commit 5f49ad7 into master Jul 22, 2024
2 checks passed
@ElvenSpellmaker ElvenSpellmaker deleted the fix/eks-irsa branch July 22, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants