feat: Adds Parent DNS Linking to AKS #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds Parent DNS Linking functionality to AKS * Bumps Major verison for new functionality * Adds 'base' domain NS records to outputs (this allows consumption from the calling code to warn about manually adding NS records to the parent DNS Zone if needed * Bumps Taskctl to the latest stable version * Renames vars.tf to variables.tf * Moves DNS code to a new DNS TF file * Adds a .editorconfig * Formatting changes * Passes tags to some resources that didn't have it passed * Updates exmaple for AKS to work with module changes * Updates Module README
ElvenSpellmaker
force-pushed
the
feat/domain-setup
branch
from
38113af to
b801c3e
Compare
ElvenSpellmaker
force-pushed
the
feat/domain-setup
branch
from
b7b8982 to
3b448fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
A description of the change.
from the calling code to warn about manually adding NS records to
the parent DNS Zone if needed
🤔 Why
Adds the ability to link the Environment DNS with the Parent/Base DNS.
🛠 How
👀 Evidence
🕵️ How to test
Run Exmaple for AKS and you'll see it work
✅ Acceptance criteria Checklist