Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding node instance tenancy variable #109

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

ravisinghkr
Copy link
Contributor

📲 What

Adding EKS node instance tenancy as a variable.

🤔 Why

In Pay.UK we need to use dediacted instances for the EKS nodes instead of the default shared instances. So making tenancy as a variable and setting the default value to 'default' which corresponds to shared instances.

@ElvenSpellmaker
Copy link
Contributor

Hey @ravisinghkr, have you tested this works (try spinning up the example with the tenancy set).

When I last checked managed node groups couldn't use the tenancy flag, only self managed.

1 similar comment
@ElvenSpellmaker
Copy link
Contributor

Hey @ravisinghkr, have you tested this works (try spinning up the example with the tenancy set).

When I last checked managed node groups couldn't use the tenancy flag, only self managed.

@ravisinghkr
Copy link
Contributor Author

ravisinghkr commented Jan 9, 2024

Hey @ravisinghkr, have you tested this works (try spinning up the example with the tenancy set).

When I last checked managed node groups couldn't use the tenancy flag, only self managed.

Yeah I am creating a cluster to test this. And yes it was possible with self managed earlier but now it is supported in eks managed node group as well.

@ElvenSpellmaker
Copy link
Contributor

Hey @ravisinghkr, have you tested this works (try spinning up the example with the tenancy set).
When I last checked managed node groups couldn't use the tenancy flag, only self managed.

Yeah I am creating a cluster to test this. And yes it was possible with self managed earlier but now it is supported in eks managed node group as well.

Nice!!

@ravisinghkr
Copy link
Contributor Author

ravisinghkr commented Jan 9, 2024

Hey @ravisinghkr, have you tested this works (try spinning up the example with the tenancy set).
When I last checked managed node groups couldn't use the tenancy flag, only self managed.

Yeah I am creating a cluster to test this. And yes it was possible with self managed earlier but now it is supported in eks managed node group as well.

Nice!!

@ElvenSpellmaker EKS cluster is created with node having dedicated tenancy

@ravisinghkr ravisinghkr merged commit dec5144 into master Jan 9, 2024
2 checks passed
@ravisinghkr ravisinghkr deleted the add-node-tenancy branch January 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants