Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a generator for Pact Consumer contract testing #323

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

JackMidd-Amido
Copy link

πŸ“² What

Created a new generator for creating a sample Pact Contract Testing solution

πŸ€” Why

This will allow teams to accelerate spinning up a contract testing solution on projects

πŸ›  How

πŸ‘€ Evidence

πŸ•΅οΈ How to test

βœ… Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@cloudratha
Copy link
Collaborator

@JackMidd-Amido please rebase against main.

Copy link

nx-cloud bot commented Oct 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f0ab285. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 1 target

Sent with πŸ’Œ from NxCloud.

Copy link
Collaborator

@cloudratha cloudratha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should catch up to run through the desired outcome

@@ -0,0 +1,17 @@
{
"name": "pact-consumer-tests",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be something like @ensono-stacks/pact-consumer-tests

@@ -0,0 +1,26 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we generate a package.json in the project files? Should we not add these as dependencies?

# dependencies
node_modules/

/msw_generated_pacts/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOL

root: projectRoot,
projectType: 'library',
sourceRoot: `${projectRoot}/src`,
targets: {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some targets to execute tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants