Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/4750 controller delegate to service #889

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Feature/4750 controller delegate to service #889

merged 2 commits into from
Jul 19, 2022

Conversation

sdavis-amido
Copy link
Contributor

4750 - Delegate business logic to Service classes

📲 What

Delegate business logic to service classes rather than performing in Controllers.

🤔 Why

Promote separation of concerns.

🛠 How

See ADR Java #31

👀 Evidence

N/A

🕵️ How to test

mvn clean test

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • [] Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@sdavis-amido
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sdavis-amido sdavis-amido merged commit f0353dc into master Jul 19, 2022
@sdavis-amido sdavis-amido deleted the feature/4750-Controller-Delegate-To-Service branch July 19, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshkrishnan-mr sureshkrishnan-mr sureshkrishnan-mr approved these changes

@msamandi msamandi Awaiting requested review from msamandi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdavis-amido @sureshkrishnan-mr