Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mvn settings cli #726

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Fix/mvn settings cli #726

merged 3 commits into from
Dec 22, 2021

Conversation

guillermogutierrez
Copy link
Contributor

[XXXX-<Title> - Please use the Work Item number and Title as PR Name, not subtasks]

📲 What

Autogenerates the maven settings.xml file

🤔 Why

The archetype:generate-from-project needs the settings.xml to be present in the local environment. As this is not a mandatory maven file, we need to ensure that a version exists, if not the build will fail.

🛠 How

Plugin (write-text-files-maven-plugin) capable to generate files has been added to the stacksclipom.xml file

<groupId>ru.yaal.maven</groupId>
<artifactId>write-text-files-maven-plugin</artifactId>
<version>1.1</version>

Also two new profiles were added (generate-settings-file and clean-workload)

  • generate-settings-file. Is responsible for generate and store a temp settings file in ${output.basedir}/settings.xml
  • clean-workload. Deletes the file once the entire CLI process is completed.

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR

🕵️ How to test

Notes for QA

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

dependabot bot and others added 3 commits December 18, 2021 18:33
Bumps log4j-api from 2.16.0 to 2.17.0.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…g.apache.logging.log4j-log4j-api-2.17.0' into fix/mvn-settings-cli
@guillermogutierrez
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@guillermogutierrez guillermogutierrez merged commit 9d92c3c into master Dec 22, 2021
@guillermogutierrez guillermogutierrez deleted the fix/mvn-settings-cli branch December 22, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants