Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3776] Java - change the way the Azure function infrastructure is deployed #89

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

russellseymour
Copy link
Collaborator

📲 What

Change the tier for the Azure App Service Plan from Elastic Premium to Standard and only deploy one of these. Both functions will be deployed to the same App Service Plan.

🤔 Why

The EP tier was originally used as it was thought this was what was required for running Containers. However this is not the case.

Running two App Service Plans was a mistake.

The reason for doing this is to reduce costs.

🛠 How

In the Terraform template perform the following tasks:

remove one of the app service plans
change the SKU to Standard on the remaining App Service Plan and rename it
Reconfigure both functions to use the single app service plan

👀 Evidence

All stages of the build have completed as normal

🕵️ How to test

Notes for QA
✅ Acceptance criteria Checklist

Code peer reviewed?
Documentation has been updated to reflect the changes?
Passing all automated tests, including a successful deployment?
Passing any exploratory testing?
Rebased/merged with latest changes from development and re-tested?
Meeting the Coding Standards?

Both functions deployed to this plan

Signed-off-by: Russell Seymour <[email protected]>
@russellseymour
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@russellseymour russellseymour merged commit 96774f4 into main Oct 12, 2021
@russellseymour russellseymour deleted the russellseymour/fix-function-costs branch October 12, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants