Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a buggy test #88

Merged
merged 4 commits into from
Oct 6, 2021
Merged

fixed a buggy test #88

merged 4 commits into from
Oct 6, 2021

Conversation

johnsall
Copy link
Contributor

@johnsall johnsall commented Oct 6, 2021

[XXXX-<Title> - Please use the Work Item number and Title as PR Name, not subtasks]

📲 What

Explicitly set the j'ackson.deserialization.fail-on-unknown-properties' to 'false'

🤔 Why

Iif there are more api arguments in the body of an api call it would nake some tests fail in certain environments but not all

🛠 How

added a bit of config to ignore validation of extra fields

👀 Evidence

Screenshots / external resources / links / etc.
Link to documentation updated with changes impacted in the PR

🕵️ How to test

Notes for QA

✅ Acceptance criteria Checklist

  • Code peer reviewed?
  • Documentation has been updated to reflect the changes?
  • Passing all automated tests, including a successful deployment?
  • Passing any exploratory testing?
  • Rebased/merged with latest changes from development and re-tested?
  • Meeting the Coding Standards?

@johnsall
Copy link
Contributor Author

johnsall commented Oct 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ElvenSpellmaker
Copy link
Contributor

@johnsall Shouldn't we also update the jackson config to catch this in future?

@johnsall
Copy link
Contributor Author

johnsall commented Oct 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…to false to ignore extra fields in the API calls
@johnsall
Copy link
Contributor Author

johnsall commented Oct 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johnsall johnsall merged commit 423b202 into main Oct 6, 2021
@guillermogutierrez guillermogutierrez deleted the test-validation-bug-fix branch December 16, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants