[3597] Use variable template for stacks-java-cqrs-events #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AB#3597 Signed-off-by: Russell Seymour <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Russell Seymour <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Russell Seymour <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Added to Prod deployment Signed-off-by: Russell Seymour <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Russell Seymour <[email protected]>
|
LGTM |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Move the top level variable out of the main pipeline file into a separate file.
AB#3597
🤔 Why
The Stacks CLI currently performs a search and replace on the template file to change the values based on the user input to the CLI. This is brittle because the original value could change and the CLI would not replace the value correctly.
By making this a separate file the CLI is able to build up the file as needed, without the need for any text replacements.
🛠 How
All of the variables are written to the variable template file,
azuredevops-vars.yaml. This is included in the main build file, e.g.👀 Evidence
The builds are working as before
🕵️ How to test
Notes for QA
✅ Acceptance criteria Checklist
Code peer reviewed?
Documentation has been updated to reflect the changes?
Passing all automated tests, including a successful deployment?
Passing any exploratory testing?
Rebased/merged with latest changes from development and re-tested?
Meeting the Coding Standards?