Bump to rules_scala-6.5.0, update repo name patch #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details: - https://github.com/bazelbuild/rules_scala/releases/tag/v6.5.0 Removes the part of the patch that worked around the removal of `to_proto` and `to_json` members from a struct, since this version contains a fix: - bazelbuild/rules_scala#1554 Updates the remaining part of the patch to define `_unmangle_bzlmod_repo_name`. This is in anticipation of the Bazel maintainers replacing `~` as the canonical repo name format delimiter due to build performance issues on Windows: - bazelbuild/bazel#22865 Signed-off-by: Mike Bland <[email protected]>
benjaminp
approved these changes
Jul 8, 2024
jayconrod
approved these changes
Jul 8, 2024
Ah, that's why they're replacing |
|
That's in the PR/commit description, too. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Removes the part of the patch that worked around the removal of
to_protoandto_jsonmembers from a struct, since this version contains a fix:Updates the remaining part of the patch to define
_unmangle_bzlmod_repo_name. This is in anticipation of the Bazel maintainers replacing~as the canonical repo name format delimiter due to build performance issues on Windows:I plan to see about contributing this function to bazelbuild/bazel-skylib eventually.