Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NodeJS version to 16 #159

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Bump NodeJS version to 16 #159

merged 2 commits into from
Oct 17, 2022

Conversation

carrodher
Copy link
Contributor

@carrodher carrodher commented Oct 17, 2022 •
edited
Loading

This PRs bumps the NodeJS version to 16 since NodeJS 12 is deprecated, here you can find more info.

Changes were done as follows:

  • Modify action.yml by bumping the node version
  • Modify the package.json by bumping the package version in a major
  • Run npm update using
    • node --version = v16.18.0
    • npm --version = 8.19.2

Bump NodeJS version to 16
eb5c80e 
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@EndBug EndBug added good first issue Good for newcomers type: fix Updates to existing functionalities labels Oct 17, 2022
EndBug
EndBug requested changes Oct 17, 2022
View reviewed changes
Copy link
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR!
Can you please remove the version bump from the changes? I'll bump the version after pushing a couple of other changes.
Also, I'll be using a patch bump, and not a major, since changing the Node version doesn't break anything for the end user.
Thanks ❤️

@EndBug EndBug self-assigned this Oct 17, 2022
Revert version bump
76e3424 
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher
Copy link
Contributor Author

Hi, thanks for the PR! Can you please remove the version bump from the changes? I'll bump the version after pushing a couple of other changes. Also, I'll be using a patch bump, and not a major, since changing the Node version doesn't break anything for the end user. Thanks ❤️

Done! I just reverted the changes related to the version bump

EndBug
EndBug approved these changes Oct 17, 2022
View reviewed changes
Copy link
Owner

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@EndBug EndBug merged commit a34bcf8 into EndBug:main Oct 17, 2022
@EndBug
Copy link
Owner

EndBug commented Oct 17, 2022

@all-contributors please add @carrodher for their code contribution

@allcontributors allcontributors bot mentioned this pull request Oct 17, 2022
Merged
@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @carrodher! 🎉

@carrodher carrodher deleted the bumpNodeJS branch October 18, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndBug EndBug EndBug approved these changes

Assignees

@EndBug EndBug

Labels
good first issue Good for newcomers type: fix Updates to existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carrodher @EndBug