Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Replace images during image build time #3752

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

lulf
Copy link
Member

@lulf lulf commented Jan 24, 2020

Type of change

  • Refactoring

Description

Replacing images during image build time instead of during source
build time allows for building the manifest image build in a separate
stage after the main images.

Checklist

  • Update/write design documentation in ./documentation/design
  • Write tests and make sure they pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

Replacing images during image build time instead of during source
build time allows for building the manifest image build in a separate
stage after the main images.
@lulf lulf requested review from k-wall and famarting January 24, 2020 12:17
@famarting
Copy link
Contributor

@enmasse-ci run tests profile=smoke OLM

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 3
FAIL: 0
SKIP: 0

@lulf lulf merged commit e868416 into master Jan 27, 2020
@lulf lulf deleted the olm-delayed-image-replace branch January 27, 2020 11:54
@k-wall k-wall added this to the 0.31 milestone Feb 26, 2020
jbtrystram pushed a commit to jbtrystram/enmasse that referenced this pull request Mar 30, 2020
Replacing images during image build time instead of during source
build time allows for building the manifest image build in a separate
stage after the main images.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants