Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Remove api-server module #3569

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

lulf
Copy link
Member

@lulf lulf commented Dec 10, 2019

Type of change

  • Refactoring

Description

Remove all code related to api-server as well as build system references
to it.

Moves swagger definition to documentation module for the time being, and
add configuration in documentation to replace properties in
swagger.json. Eventually this should be generated from the CRDs.

Checklist

  • Update/write design documentation in ./documentation/design
  • Write tests and make sure they pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@lulf lulf requested a review from k-wall December 10, 2019 10:36
@lulf lulf force-pushed the remove-api-server branch from dd34ce4 to 7817e06 Compare December 10, 2019 10:39
Remove all code related to api-server as well as build system references
to it.

Moves swagger definition to documentation module for the time being, and
add configuration in documentation to replace properties in
swagger.json. Eventually this should be generated from the CRDs.
@lulf lulf force-pushed the remove-api-server branch from 7817e06 to 375a00a Compare December 10, 2019 10:42
@lulf lulf requested a review from kornys December 10, 2019 10:42
@kornys
Copy link
Member

kornys commented Dec 10, 2019

@enmasse-ci run tests profile=smoke

@kornys
Copy link
Member

kornys commented Dec 10, 2019

@lulf you can also remove creating api-server certs in systemtests OperatorManager.java and in travis, right?

@lulf
Copy link
Member Author

lulf commented Dec 10, 2019

@kornys this should be the case already

Copy link
Member

@k-wall k-wall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greeeaat :)

@lulf
Copy link
Member Author

lulf commented Dec 10, 2019

@enmasse-ci run tests profile=isolated testcase=CommonTest#testMessagingDuringRestartComponents

@enmasse-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 2
FAIL: 1
SKIP: 0

❗ Test Failures ❗

  • testCreateDeleteAddressSpace in io.enmasse.systemtest.isolated.brokered.SmokeTest

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: isolated
TEST_CASE: CommonTest#testMessagingDuringRestartComponents
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0

@lulf lulf merged commit 4892338 into EnMasseProject:master Dec 10, 2019
@lulf lulf deleted the remove-api-server branch December 10, 2019 12:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants