This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Build cleanup #3261
Merged
Build cleanup #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enmasse-ci run tests profile=smoke |
k-wall
reviewed
Oct 3, 2019
k-wall
reviewed
Oct 3, 2019
| @@ -1,6 +1,6 @@ | |||
| # variables used in the olm yaml files | |||
|
|
|||
| VERSIONED_NAME=enmasse.${VERSION}.0 | |||
| VERSIONED_NAME=enmasse.${MAVEN_VERSION} | |||
There was a problem hiding this comment.
As VERSIONED_NAME is used as the basis of the Operator's version number, don't we need to maintain a level of indirection to suit downstream builds?
There was a problem hiding this comment.
There is already a downstream patch to set a different value for this field. This prevents the need to change an additional line in templates/csv/enmasse.package.yaml
✔️ Test Summary ✔️TEST_PROFILE: smoke |
added 2 commits
October 3, 2019 10:36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Select the type of your PR
Checklist
Please go through this checklist and make sure all applicable tasks have been done
./documentation/design