Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory setting mode #140

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

Peguy-WANDA
Copy link
Contributor

No description provided.

Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand what this is trying to do. However, I think the user options are starting to get really complicated. I.e. how is the user supposed to interact with the Keypad?

Could you please create a documentation user-manual.md in the docs folder that explains all the options and flows for the user? Or maybe that's something @frimic-solarly can help out with?

Comment on lines 1 to 5
.pio
.vscode/.browse.c_cpp.db*
.vscode/c_cpp_properties.json
.vscode/launch.json
.vscode/ipch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Peguy-WANDA you seem to have this file in every PR you send 😉 Please, either delete it locally, or commit file-by-file and not all files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Daniel, Ok it was a mistake sorry, So let me remove it

@frimic-solarly
Copy link
Contributor

I think I understand what this is trying to do. However, I think the user options are starting to get really complicated. I.e. how is the user supposed to interact with the Keypad?

Could you please create a documentation user-manual.md in the docs folder that explains all the options and flows for the user? Or maybe that's something @frimic-solarly can help out with?

Hello Daniel, I think, if I'm not mistaken, that the whole factory settings menu is available for technicians but not for the end-user. @Peguy-WANDA will start the testing and will do videos and pictures for us to better understand how this will be articulated.
I'll also take care of the documentation to make it clear for any newcomers.

@dmohns dmohns merged commit 3647222 into main Nov 14, 2023
@dmohns dmohns deleted the Factory-setting-Reinitialisation-of-value branch November 14, 2023 09:46
dmohns added a commit that referenced this pull request Dec 20, 2023
dmohns added a commit that referenced this pull request Dec 20, 2023
dmohns added a commit that referenced this pull request Dec 20, 2023
dmohns added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants