Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update rust crate sentry-core to 0.31.5 #26

Closed
wants to merge 1 commit into from

Conversation

poliorcetics
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Update sentry-core to 0.31 releases

Related Issues

None

Copy link
Contributor

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>=0.29 already allows 0.31 and up. This was a conscious choice because the updates were coming in too hot, and are typically code-compatible.

Instead an upper bound should be added and released if it turns out to be incompatible with a newer version, and a new version should be released with the lower bound restarting at the new version together with the necessary breaking changes.

As it stands this PR adds nothing besides unnecessarily disallowing users from using sentry-contrib-rust with older versions of sentry-core.

@Jake-Shadle
Copy link
Member

Like @MarijnS95 said, this change doesn't meaningfully change anything other than unnecessarily stopping people from using (compatible) older versions of sentry-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants