Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asm: support OpCompositeExtract inference for OpTypeStruct fields. #803

Merged
merged 1 commit into from
Nov 22, 2021
Merged

asm: support OpCompositeExtract inference for OpTypeStruct fields. #803

merged 1 commit into from
Nov 22, 2021

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Nov 20, 2021

The motivation for this was unchecked indexing via asm!, on &[T] (as can be seen in the test) - all the pieces were there, except for the OpCompositeExtract to get the data pointer part of the &[T].

@eddyb eddyb requested a review from khyperia as a code owner November 20, 2021 21:24
Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@khyperia khyperia merged commit 553f79e into EmbarkStudios:main Nov 22, 2021
@eddyb eddyb deleted the infer-access-chain-slice branch November 22, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants