peer: add peer_has_error #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the case where peer->error is sometimes an empty string Fixes ElementsProject#435
|
hmm this made things worse 🤔 will have to think about this some more |
anaoum
reviewed
Dec 13, 2017
| @@ -189,7 +189,7 @@ void peer_fail_permanent(struct peer *peer, const u8 *msg TAKES) | |||
| (int)tal_len(msg), (char *)msg); | |||
|
|
|||
| /* We can have multiple errors, eg. onchaind failures. */ | |||
| if (!peer->error) | |||
| if (peer_has_error(peer)) | |||
There was a problem hiding this comment.
You have omitted the not operator here !
anaoum
reviewed
Dec 13, 2017
| @@ -133,6 +133,11 @@ static inline bool peer_on_chain(const struct peer *peer) | |||
| return peer_state_on_chain(peer->state); | |||
| } | |||
|
|
|||
| static inline bool peer_has_error(const struct peer *peer) | |||
| { | |||
| return peer->error == NULL || peer->error[0] == '\0'; | |||
There was a problem hiding this comment.
should has error be checking if peer->error is equal to NULL or not equal to NULL?
There was a problem hiding this comment.
you're right! brain malfunction :|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where peer->error is sometimes an empty string
Fixes #435