Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have gossipd generate node_announcement automatically #320

Closed
rustyrussell opened this issue Oct 24, 2017 · 3 comments · Fixed by #413
Closed

Have gossipd generate node_announcement automatically #320

rustyrussell opened this issue Oct 24, 2017 · 3 comments · Fixed by #413
Assignees
Labels
Milestone

Comments

@rustyrussell
Copy link
Contributor

  1. Change hsmd so gossip can ask for sigs on node_announcement.
  2. Pass addresses, color and alias through to gossipd.
  3. Have gossipd handle_channel_announcement return true if msg is about us, and new.
  4. Move signing code from master to gossipd.
@rustyrussell
Copy link
Contributor Author

Moved to 0.6, since it's happening with more regularity now.

@cdecker
Copy link
Member

cdecker commented Dec 8, 2017

Agreed, will slice up the big PR I am currently debugging to fix this first, before addressing #284 which still has a flaky test when running in valgrind

rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 11, 2017
Rather than routing via master, we send to channeld.  It then creates
node announcement.

Closes: ElementsProject#320
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell
Copy link
Contributor Author

rustyrussell commented Dec 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants