Some fixes based on user feedback and real-world usage #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 96.56% 97.53% +0.96%
==========================================
Files 8 8
Lines 612 649 +37
==========================================
+ Hits 591 633 +42
+ Misses 21 16 -5
☔ View full report in Codecov by Sentry. |
jkeifer
force-pushed
the
jak/updates
branch
2 times, most recently
from
97256a4 to
7ce59ed
Compare
Rather than requiring the user to create and update the schema version table in their schema.sql, that table will be automatically handled by dbami when loading the schema similar to how it is for migrations. The schema version value is now populated via the max migration version, and means we absolutely require a starting migration now, so the 0 migration is created by `init`. These changes also clean up handling of a rollback attempt of the base migration by explicitly highlighting that it isn't supported.
geomatician
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schema.sqlexecute_sqlmethod on theDBclass to allow execution of arbitrary sql without having to make aSqlFileinstance__main__.main()as the entry point for CLI testing to ensure that file is tested