feat: 增加水球图 #542
Merged
feat: 增加水球图 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
基于ecahrts-liquidfill，增加对水球图的封装
xiguaxigua
reviewed
Oct 2, 2018
examples/data/liquidfill.js
Outdated
| color: ['red', 'green', 'yellow'], | ||
| label: { | ||
| formatter (options) { | ||
| return options.seriesName + ': ' + options.value |
There was a problem hiding this comment.
return ${options.seriesName}:${options.value}
xiguaxigua
reviewed
Oct 2, 2018
src/packages/liquidfill/main.js
Outdated
| if (!isNaN(val)) { | ||
| data.push({ value: val }) | ||
| if (itemMap['wave'] && isArray(itemMap['wave'])) { | ||
| layers = itemMap['wave'].filter(num => typeof num === 'number' && val > num).sort((a, b) => a < b).map(val => ({ value: val })) |
There was a problem hiding this comment.
应该不需要对数值做判断，只要把值直接添加上去就行了。
xiguaxigua
reviewed
Oct 2, 2018
src/packages/liquidfill/main.js
Outdated
| if (itemMap['wave'] && isArray(itemMap['wave'])) { | ||
| layers = itemMap['wave'].filter(num => typeof num === 'number' && val > num).sort((a, b) => a < b).map(val => ({ value: val })) | ||
| data = data.concat(layers) | ||
| delete itemMap['wave'] |
There was a problem hiding this comment.
这个属性可以放到settings里
settings.wave = [0.1, 0.2, 0.3]
settings.wave = [[0,1, 0.2, 0.3], [0.1, 0.2, 0.3]]
xiguaxigua
reviewed
Oct 2, 2018
src/packages/liquidfill/main.js
Outdated
| results.push(result) | ||
| }) | ||
|
|
||
| if (results.length > 1) { |
There was a problem hiding this comment.
位置最好是不要做特殊处理，让用户来配置，可以省去很多麻烦。
xiguaxigua
approved these changes
Oct 4, 2018
xiguaxigua
reviewed
Oct 4, 2018
xiguaxigua
approved these changes
Oct 7, 2018
docs/en/liquidfill.md
Outdated
| chartData: { | ||
| columns: ['city', 'percent'], | ||
| rows: [{ | ||
| city: '上海', |
docs/en/liquidfill.md
Outdated
| | metrics | metrics of chart data | String | default `columns[1]` | | ||
| | dataType | type of data | String | default `percent`, also can be setted as `normal` | | ||
| | digit | Set the number of digits to retain when the dataType is `percent` | Number | default `2` | | ||
| | wave | set the liquidfill layering | Array[Number]，Array[Array[Number]] | default `[]`, The value in the array is not greater than the dimension value in the row, and needs to be arranged from large to small. It can be setted like [0.3, 0.2, 0.1]，which represents each liquidfill shows four layers and the values of bottom layers are 0.1、0.2、0.3 from bottom to top；It also can be setted like [[0.2, 0.1], [0.1], []].When there are a few liquidfill balls, Each item in the wave corresponds to a hierarchical setting of a liquidfill ball.If the wave.length is less than the rows.length, the left liquidfill will be setted according to the last value of wave. For example, the rows is [{val: 0.1}, {val: 0.2}, {val: 0.3}, {val: 0.4}], and the wave is [[0.2,0.1], [0.2]].此时Now the last three items's layering of rows will be setted as [0.2]. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
What Changed
基于ecahrts-liquidfill，增加对水球图的封装
Breaking Change
Document Update