Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Fix dialog body correctly break long words #15027

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Dialog: Fix dialog body correctly break long words #15027

merged 1 commit into from
Apr 18, 2019

Conversation

iamkun
Copy link
Member

@iamkun iamkun commented Apr 9, 2019

fix #14855

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit ddc7085

https://deploy-preview-15027--element.netlify.com

@iamkun iamkun added this to the 2.8.0 milestone Apr 10, 2019
@ziyoung ziyoung merged commit ec0295f into ElemeFE:dev Apr 18, 2019
@iamkun iamkun deleted the fix/dialog-word branch May 6, 2019 07:02
FAKER-A added a commit to FAKER-A/element that referenced this pull request May 7, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
@d--j
Copy link

d--j commented Jan 16, 2020

This is too aggressive. word-break: break-all; breaks apart words even when it is not necessary.
It is common to nest e.g. an <el-table> inside an <el-dialog>. Then all columns of that table inherit the word-break: break-all; and you explicitly need to overwrite that so that the layout does not gets broken.

See https://jsfiddle.net/5c9x3p6e/
Edit_fiddle_-_JSFiddle

Maybe overflow-wrap: break-word; is better – or leave #14855 to be fixed on a case by case basis (when you have long lines in a tiny <el-dialog>, add your own CSS like in https://jsfiddle.net/dLsnc8v4/ )

lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] words can not be break in the dialog
4 participants