Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: fix style when label-width is auto #14955

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Form: fix style when label-width is auto #14955

merged 1 commit into from
Apr 3, 2019

Conversation

ziyoung
Copy link
Contributor

@ziyoung ziyoung commented Apr 3, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 8b26878

https://deploy-preview-14955--element.netlify.com

@ziyoung ziyoung merged commit 901ff0e into ElemeFE:dev Apr 3, 2019
@ziyoung ziyoung mentioned this pull request Apr 3, 2019
3 tasks
@de1ck
Copy link

de1ck commented Apr 4, 2019

valdator required: true red tag is miss

@ziyoung
Copy link
Contributor Author

ziyoung commented Apr 16, 2019

valdator required: true red tag is miss

Yes. I will fix it soon.

@iTaster
Copy link

iTaster commented Apr 17, 2019

The problem has not been fixed

error in ./~/element-ui/packages/form/src/label-wrap.vue

Syntax Error: Unexpected token (21:8)

} return ( <div class="el-form-item__label-wrap" style={style}> { slots } </div>) } else {

<div class="el-form-item__label-wrap" style={style}> { slots } </div>
fix Using template strings

@ziyoung
Copy link
Contributor Author

ziyoung commented Apr 17, 2019

@iTaster can't reproduce. Please provide a demo.

weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants