Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabs:修复el-tab其中一个选择器默认颜色不是变量的问题 #14558

Merged
merged 1 commit into from
Mar 25, 2019
Merged

tabs:修复el-tab其中一个选择器默认颜色不是变量的问题 #14558

merged 1 commit into from
Mar 25, 2019

Conversation

Richard-Choooou
Copy link
Contributor

@Richard-Choooou Richard-Choooou commented Mar 4, 2019 •
edited
Loading

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

el-tab其中一个选择器默认颜色不是变量，导致修改主色调后，这个属性的默认颜色还是 ‘#409eff’

@element-bot
Copy link
Member

Deploy preview for element ready!

Built with commit 67e6805

https://deploy-preview-14558--element.netlify.com

@Richard-Choooou Richard-Choooou changed the title 修复el-tab其中一个选择器默认颜色不是变量的问题 tabs:修复el-tab其中一个选择器默认颜色不是变量的问题 Mar 4, 2019
@ziyoung
Copy link
Contributor

ziyoung commented Mar 4, 2019

@Richard-Choooou 请提供一个复现的 demo。

@ziyoung ziyoung added this to the 2.7.0 milestone Mar 4, 2019
@Richard-Choooou
Copy link
Contributor Author

@Richard-Choooou 请提供一个复现的 demo。

我尝试一下，这个不太好复现

@Richard-Choooou
Copy link
Contributor Author

@ziyoung https://codepen.io/anon/pen/moELZd 点击切换选项可以复现

@ziyoung
Copy link
Contributor

ziyoung commented Mar 4, 2019 •
edited
Loading

@Richard-Choooou

kapture 2019-03-04 at 18 02 59
你这个是修复好了的？

我在官网上测试，没发现你提出的问题。https://cube.elemecdn.com/5/68/e06f79e3be65efc45b2cd9af1f99dmp4.mp4

@Richard-Choooou
Copy link
Contributor Author

Richard-Choooou commented Mar 4, 2019 •
edited
Loading

  1. 触发条件：点击切换后，需弹出confirm提示框，主要是这一段选择器起了作用
    https://github.com/ElemeFE/element/blob/dev/packages/theme-chalk/src/tabs.scss#L110-L115

  2. 因为官网切换主题色会直接将 主色号字符串进行替换，所以会覆盖掉这里设置的颜色，所以在官网是不能复现的

  3. 如果仅使用覆盖element 默认scss变量的方式，会复现这个问题，因为这里使用的固定的色值，而不是变量，所以打包后，这里的颜色不会是自定义的颜色。
    @ziyoung

@ziyoung ziyoung merged commit 362953e into ElemeFE:dev Mar 25, 2019
weisiren168 pushed a commit to weisiren168/element that referenced this pull request Jun 20, 2019
@Richard-Choooou
Tabs: use primary color as boxShadow color (ElemeFE#14558)
8572de1
lzq4047 pushed a commit to lzq4047/element that referenced this pull request May 22, 2020
@Richard-Choooou @lzq4047
Tabs: use primary color as boxShadow color (ElemeFE#14558)
77b32ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyoung ziyoung ziyoung approved these changes

Assignees

@ziyoung ziyoung

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Richard-Choooou @element-bot @ziyoung