Reduce chance of detecting false positives when scanning subprocesses for errors. #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160
The problem is that
ng build
logs lines like the following:The original code detects this as an error, unintentionally. The problem is compounded by the fact that the build process uses backspace characters, which means the "offending" line is invisible to end users.
This fix doesn't address the fact that scanning for "error" is a horrible hack, but I'm sure you've already explored the alternatives. Instead, I've made the smallest change possible that will continue to detect any likely error, while ignoring these problematic files. Fortunately, no file called "error.js" is installed, at least when I tested (Windowx x64, netcoreapp2.1, default new angular project).