Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce chance of detecting false positives when scanning subprocesses for errors. #236

Conversation

BorisTheBrave
Copy link
Contributor

Fixes #160

The problem is that ng build logs lines like the following:

20% building modules 90/102 modules 12 active 
...modules\\rxjs\\_esm5\\util\\EmptyError.js

The original code detects this as an error, unintentionally. The problem is compounded by the fact that the build process uses backspace characters, which means the "offending" line is invisible to end users.

This fix doesn't address the fact that scanning for "error" is a horrible hack, but I'm sure you've already explored the alternatives. Instead, I've made the smallest change possible that will continue to detect any likely error, while ignoring these problematic files. Fortunately, no file called "error.js" is installed, at least when I tested (Windowx x64, netcoreapp2.1, default new angular project).

@GregorBiswanger GregorBiswanger merged commit 8d6a5a7 into ElectronNET:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to build when using dotnet spa templates
2 participants