Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link: align two hover colors with the latest design spec #719

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Updates --anchor-neutral-hover-color to --grey-secondary-color
  • Updates --anchor-secondary-hover-color to --grey-color-90

JIRA TASK (Eightfold Employees Only):

ENG-52998

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the above link colors.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fd03a23:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@dkilgore-eightfold dkilgore-eightfold merged commit 8bc7e24 into EightfoldAI:main Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants