Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination: bug fixes for simplified pagination #581

Conversation

rnori-eightfold
Copy link
Contributor

@rnori-eightfold rnori-eightfold commented Apr 3, 2023

SUMMARY:

  • Remove extra padding on the top in case of simplified pagination
  • Fix total prop description
  • Show simplified pagination only when there is more than one page
  • Use pageSizes prop only when layout has PaginationLayoutOptions.Sizes
  • Fix usage of Pagination in Carousel component

JIRA TASK (Eightfold Employees Only):

N/A

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn, yarn storybook. Verify all types of Pagination, Carousel behave as expected.

@rnori-eightfold rnori-eightfold changed the title Fixes for simplified pager Fixes for simplified pagination Apr 3, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0251d80:

Sandbox Source
React Configuration
Vanilla Configuration

@rnori-eightfold rnori-eightfold self-assigned this Apr 3, 2023
@rnori-eightfold rnori-eightfold marked this pull request as ready for review April 3, 2023 22:42
@rnori-eightfold rnori-eightfold marked this pull request as draft April 3, 2023 22:46
@rnori-eightfold rnori-eightfold removed the request for review from dkilgore-eightfold April 3, 2023 23:00
@rnori-eightfold rnori-eightfold marked this pull request as ready for review April 3, 2023 23:34
@rnori-eightfold rnori-eightfold changed the title Fixes for simplified pagination fix: pagination: bug fixes for simplified pagination Apr 3, 2023
@rnori-eightfold rnori-eightfold removed the request for review from jhoward-eightfold April 4, 2023 04:58
@rnori-eightfold rnori-eightfold force-pushed the rnori-eightfold/simplified-pager-bug-fixes branch from dd74019 to f191f97 Compare April 4, 2023 21:33
use pageSize prop instead of pageSizes
there is some extra padding on the top in case of simplified pagination
@rnori-eightfold rnori-eightfold force-pushed the rnori-eightfold/simplified-pager-bug-fixes branch from f191f97 to 646a52d Compare April 4, 2023 21:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f6b9a4e). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage        ?   84.81%           
=======================================
  Files           ?      792           
  Lines           ?    17144           
  Branches        ?     6045           
=======================================
  Hits            ?    14540           
  Misses          ?     2538           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rnori-eightfold and others added 2 commits April 6, 2023 01:28
@rnori-eightfold rnori-eightfold force-pushed the rnori-eightfold/simplified-pager-bug-fixes branch from 9120ffe to dc14546 Compare April 5, 2023 20:37
@dkilgore-eightfold dkilgore-eightfold self-requested a review April 5, 2023 22:05
Controls number of pages displayed b/w ... buttons
@rnori-eightfold rnori-eightfold force-pushed the rnori-eightfold/simplified-pager-bug-fixes branch from dfca9d0 to 0251d80 Compare April 5, 2023 22:36
@ranjithnori
Copy link

:shipit:

@rnori-eightfold rnori-eightfold merged commit c6b83cc into EightfoldAI:main Apr 5, 2023
@rnori-eightfold rnori-eightfold deleted the rnori-eightfold/simplified-pager-bug-fixes branch May 2, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants