Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new alarm icon. #573

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

mmusaddi-eightfold
Copy link
Contributor

SUMMARY:

Add new alarm icon based on chrome extension figma.

GITHUB ISSUE (Open Source Contributors)

NA

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-32070

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

  • Tested in PR codesandbox
    Code:
import "./styles.css";
import { IconName, Icon, IconSize } from "@eightfold.ai/octuple";

export default function App() {
  return (
    <div className="App">
      <Icon path={IconName.mdiAlarm} color="blue" />
    </div>
  );

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f4ff34c:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@2b9f28b). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #573   +/-   ##
=======================================
  Coverage        ?   84.96%           
=======================================
  Files           ?      792           
  Lines           ?    17031           
  Branches        ?     5978           
=======================================
  Hits            ?    14471           
  Misses          ?     2494           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmusaddi-eightfold mmusaddi-eightfold merged commit f9500a1 into EightfoldAI:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants