fix: tooltip: fixes pixel position rounding error #572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
left
,top
style
positions that were floats would be auto-corrected by the browser resulting in a noticeable 1 pixel shift at run time.Tooltip
element.JIRA TASK (Eightfold Employees Only):
ENG-46933
Before fix:
tooltipBefore.mp4
After fix:
tooltipAfter.mp4
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch, run
yarn
andyarn storybook
. Verify theTooltip
behaves as expected in theAvatar
story suite.