Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip: fixes pixel position rounding error #572

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Mar 21, 2023

SUMMARY:

  • Fixes rounding error by rounding down to nearest number, previously the calculated left, top style positions that were floats would be auto-corrected by the browser resulting in a noticeable 1 pixel shift at run time.
  • Fixes class prop typo of cloned Tooltip element.

JIRA TASK (Eightfold Employees Only):

ENG-46933

Before fix:

tooltipBefore.mp4

After fix:

tooltipAfter.mp4

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch, run yarn and yarn storybook. Verify the Tooltip behaves as expected in the Avatar story suite.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54eb55b:

Sandbox Source
React Configuration
Vanilla Configuration

@dkilgore-eightfold dkilgore-eightfold merged commit 4a5a70f into EightfoldAI:main Mar 21, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@1cba3fd). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage        ?   84.94%           
=======================================
  Files           ?      791           
  Lines           ?    16923           
  Branches        ?     5948           
=======================================
  Hits            ?    14375           
  Misses          ?     2482           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants