Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carousel: only handle wheel event when not using touchpad #568

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Simplifies the scroll behavior of Carousel scroll mode by deferring touchpad scroll behavior to the browser, ensuring consistency
  • Only prevent default when using vertical mouse wheel event triggered by a proper mouse

JIRA TASK (Eightfold Employees Only):

ENG-46812

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Carousel stories behave as expected.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fa5017d:

Sandbox Source
React Configuration
Vanilla Configuration

@dkilgore-eightfold dkilgore-eightfold merged commit 045ba0e into EightfoldAI:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants