Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: status item styles, add option to place status icon before status text #567

Merged

Conversation

fmehta-eightfold
Copy link
Contributor

@fmehta-eightfold fmehta-eightfold commented Mar 20, 2023

SUMMARY:

  • Feature: Option to place status text after the status icon
  • Fix status item text font size - according to the design, the font should be 2px larger than the icon, and have font-weight: 600

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

ENG-40399

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Story book for Avatar should get updated to reflect the above mentioned feature and fix

Before
image

After
image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 28fe9e5:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@f3ddff5). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage        ?   84.96%           
=======================================
  Files           ?      792           
  Lines           ?    17031           
  Branches        ?     5978           
=======================================
  Hits            ?    14471           
  Misses          ?     2494           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fmehta-eightfold fmehta-eightfold marked this pull request as ready for review March 20, 2023 06:54
@dkilgore-eightfold
Copy link
Contributor

@fmehta-eightfold Fix the stories file with alignIcon and you should be good to go.

@fmehta-eightfold fmehta-eightfold changed the title fix: menu item btn, status item styles fix: status item styles, add option to place icon before status text Mar 23, 2023
@fmehta-eightfold fmehta-eightfold changed the title fix: status item styles, add option to place icon before status text fix: status item styles, add option to place status icon before status text Mar 23, 2023
@fmehta-eightfold fmehta-eightfold merged commit cdf866c into EightfoldAI:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants