Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar status item text and tooltip support #560

Merged

Conversation

fmehta-eightfold
Copy link
Contributor

@fmehta-eightfold fmehta-eightfold commented Mar 7, 2023

SUMMARY:

  • Add Avatar status item text and tooltip support (this is needed because we required Avatar+Tooltip support in AvatarGroup but it was not working because of use of cloneElement in AvatarGroup)
  • Improve Avatar status item placement CSS
  • Fix undesired Avatar status item displacement in AvatarGroup due to border
  • Fix Avatar outline when src is passed and type === 'round'

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

ENG-40399

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Avatar Group stories behave as expected.

Avatar status item text
image

Avatar tooltip
image

Avatar status item displacement in AvatarGroup - before and after the fix
image
image

Avatar outline when src is passed and type === 'round' - before and after the fix
image
image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 375b1bd:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4774be8). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage        ?   84.79%           
=======================================
  Files           ?      791           
  Lines           ?    16873           
  Branches        ?     5927           
=======================================
  Hits            ?    14307           
  Misses          ?     2500           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fmehta-eightfold fmehta-eightfold merged commit e478915 into EightfoldAI:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants