-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar status item text and tooltip support #560
Avatar status item text and tooltip support #560
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 375b1bd:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage ? 84.79%
=======================================
Files ? 791
Lines ? 16873
Branches ? 5927
=======================================
Hits ? 14307
Misses ? 2500
Partials ? 66 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…ehta/avatar-feat-fix
SUMMARY:
Avatar
status item text and tooltip support (this is needed because we requiredAvatar+Tooltip
support inAvatarGroup
but it was not working because of use ofcloneElement
inAvatarGroup
)Avatar
status item placement CSSAvatar
status item displacement inAvatarGroup
due to borderAvatar
outline whensrc
is passed andtype === 'round'
GITHUB ISSUE (Open Source Contributors)
JIRA TASK (Eightfold Employees Only):
ENG-40399
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run yarn and yarn storybook. Verify the Avatar Group stories behave as expected.
Avatar status item text

Avatar tooltip

Avatar status item displacement in AvatarGroup - before and after the fix


Avatar
outline whensrc
is passed andtype === 'round'
- before and after the fix