Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configprovider: update context then add locale story and unit tests #555

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Feb 25, 2023

SUMMARY:

  • Adds much needed ConfigProvider unit tests
  • Updates IConfigContext to enhance functionality
  • Adds Locale story to demonstrate basic Locale implementation and to test locales if needed
  • Updates Calendar locales to include short days and short months for each lang
  • Updates mocky.io url
  • Removes bogus prop and type from Slider
configProviderLocales.mp4

JIRA TASK (Eightfold Employees Only):

ENG-44511

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn, yarn test, and yarn storybook. Verify the ConfigProvider, Slider and Upload stories behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0e69a3:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@448e0ce). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage        ?   84.79%           
=======================================
  Files           ?      791           
  Lines           ?    16837           
  Branches        ?     5917           
=======================================
  Hits            ?    14277           
  Misses          ?     2494           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit 2e42f02 into EightfoldAI:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants