Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: icon: adds unit tests #549

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Adds Icon unit tests.

JIRA TASK (Eightfold Employees Only):

N/A

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

N/A

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 23, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6fd72c:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@2e0da40). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage        ?   84.68%           
=======================================
  Files           ?      791           
  Lines           ?    16835           
  Branches        ?     5916           
=======================================
  Hits            ?    14257           
  Misses          ?     2512           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@slee-eightfold slee-eightfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkilgore-eightfold dkilgore-eightfold merged commit feae87c into EightfoldAI:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants