fix: nudge: removes unnecessary border calculations in css #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Using a CSS variable inside of a nested
calc
function isn't valid SASS, this change removes these property overrides to fix theSize
nudge animation, because border is appended to the client rect, these overrides are unnecessary.nudgeSize.mp4
JIRA TASK (Eightfold Employees Only):
ENG-44290
CHANGE TYPE:
TEST COVERAGE:
N/A CSS only
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify thePrimaryButton
story behaves as expected when given the followingnudgeProps
: