Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nudge: removes unnecessary border calculations in css #547

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

Using a CSS variable inside of a nested calc function isn't valid SASS, this change removes these property overrides to fix the Size nudge animation, because border is appended to the client rect, these overrides are unnecessary.

nudgeSize.mp4

JIRA TASK (Eightfold Employees Only):

ENG-44290

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

N/A CSS only

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the PrimaryButton story behaves as expected when given the following nudgeProps:

{
  "animation": "size",
  "delay": 5000,
  "enabled": true,
  "iterations": 5
}

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3810257:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@25b084e). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage        ?   84.50%           
=======================================
  Files           ?      790           
  Lines           ?    16711           
  Branches        ?     5844           
=======================================
  Hits            ?    14122           
  Misses          ?     2523           
  Partials        ?       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit a0c01c7 into EightfoldAI:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants