Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding new MDI icons #481

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

karurst-eightfold
Copy link
Contributor

@karurst-eightfold karurst-eightfold commented Dec 28, 2022

SUMMARY:

Add MDI Icons.

GITHUB ISSUE (Open Source Contributors)

NA

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-38958

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

1.) Tested all added icons via local storybook and verified that they render as expected.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6566914:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@4bdfae1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #481   +/-   ##
=======================================
  Coverage        ?   84.98%           
=======================================
  Files           ?      749           
  Lines           ?    16048           
  Branches        ?     5495           
=======================================
  Hits            ?    13639           
  Misses          ?     2348           
  Partials        ?       61           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@karurst-eightfold
Copy link
Contributor Author

:shipit:

@karurst-eightfold karurst-eightfold merged commit f5ae7ea into EightfoldAI:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants