Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avatar group: add the avatar group component #422

Conversation

dkilgore-eightfold
Copy link
Contributor

SUMMARY:

  • Adds AvatarGroup component to octuple
  • Adds AvatarGroup stories file
  • Adds additional types to List component
  • Adds Avatar UTs
avatarGroup.mp4

JIRA TASK (Eightfold Employees Only):

ENG-32364

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the pr branch and run yarn then yarn storybook. Verify the Avatar, AvatarGroup and List components behave as expected.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 18, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc599ff:

Sandbox Source
React Configuration
Vanilla Configuration

src/components/Avatar/Avatar.types.ts Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.types.ts Outdated Show resolved Hide resolved
src/components/Avatar/Avatar.types.ts Outdated Show resolved Hide resolved
src/components/Avatar/Styles/group.scss Outdated Show resolved Hide resolved
@dkilgore-eightfold dkilgore-eightfold merged commit 535cfe6 into EightfoldAI:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants