Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dkilgore eightfold/select improvements #384

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Sep 21, 2022

SUMMARY:

  • Deselect option using backspace when using single select
  • Adds flip to Dropdown component floating-ui middleware
  • Adds disabled state to Pills
  • Only show tooltip if pill label is truncated
  • Adds UTs
selectBackspace.mp4
flip.mp4

JIRA TASK (Eightfold Employees Only):

ENG-29954

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

pull the pr branch and do yarn, then yarn storybook. Verify the Select stories behave as expected. You may also implement Select using Codesandbox CI.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bcca303:

Sandbox Source
React Configuration
Vanilla Configuration

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@f42be3f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage        ?   84.70%           
=======================================
  Files           ?      485           
  Lines           ?    13322           
  Branches        ?     4500           
=======================================
  Hits            ?    11285           
  Misses          ?     2013           
  Partials        ?       24           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkilgore-eightfold dkilgore-eightfold merged commit e53679e into EightfoldAI:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants